Is this a good unit test? If you read it in a tutorial book like this, it has to be. Actually, it is not. It is a good code to demonstrate some of the tools that JUnit provides and some Java language features, but as a real JUnit test, I will not use it in a real life project.

What makes a unit test good? To answer this question, we will have to find what the unit test is good for and what it is that we use it for.

Unit tests are not to find bugs. Developers eventually use unit tests during debugging sessions but, many times, the testing code created for the debugging is a temporary one. When the bug is fixed, the code used to find it will not get into the source code. For every new bug, there should be a new test created that covers the functionality that was not properly working, but it is hardly the test code that is used to find the bug. This is because unit tests are mainly for documentation. You can document a class using JavaDoc, but the experience shows that the documentation often becomes outdated. The developers modify the code, but they do not modify the documentation, and the documentation becomes obsolete and misleading. Unit tests, however, are executed by the build system and if Continuous Integration (CI) is in use (and it should be, in a professional environment), then the build will be broken if a test fails, all developers will get mail notification about it, and it will drive the developer breaking the build to fix the code or the test. This way, the tests verify that continuous development did not break anything in the code or, at least, not something that can be discovered using unit tests.